Hi I have started working in Arquillian Governor Github integration. First of all I have made some research, and before starting code I would like to discuss some things:
I have been reviewing all libraries that offers access to github. The best one in my opinion is https://github.com/eclipse/egit-github/tree/master/org.eclipse.egit.github.core because it has no dependencies to external libraries, so it is perfect because we won’t get any conflict with Json parsers, REST clients, …
Then about Governor, I think that some properties should be moved to core instead of JIRA module. For example:
closingMessage, because it is something that all integrators should implement. And this implies not only changing the configuration class but also the service interface.
Also not related with this issue I think it would be great if we could do something like Serenity BDD and make the workflow configurable, so for example apart from having automatically close feature, also open a feature when it is closed but the test has just failed.